Add nhcb samples metric in distributor#7248
Open
yeya24 wants to merge 3 commits intocortexproject:masterfrom
Open
Add nhcb samples metric in distributor#7248yeya24 wants to merge 3 commits intocortexproject:masterfrom
yeya24 wants to merge 3 commits intocortexproject:masterfrom
Conversation
yeya24
force-pushed
the
add-metric-nhcb
branch
from
a1152b4 to
794d09a
Compare
friedrichg
approved these changes
Feb 10, 2026
CharlieTLe
reviewed
Feb 11, 2026
Member
There was a problem hiding this comment.
Shouldn't we have a test that checks that there was an increase for the nhcb type? I see all these tests are only checking that the value is 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add
nhcbdimension tocortex_distributor_received_samples_totalandcortex_distributor_samples_in_totalto keep track of number of nhcb samples.Note that
cortex_distributor_received_samples_total{type="nhcb"}is a subset ofcortex_distributor_received_samples_total{type="histogram"}so doingsum(cortex_distributor_received_samples_total)will actually double count of nhcb samples.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]